You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
594: Update create duel links in anticaption of Arsh's PR
PR Type
Enhancement
Description
Redirects from create path to duel root
Aligns error redirects to new route
Updates empty-state redirects for duels
Diagram Walkthrough
flowchart LR
A["Legacy redirect to /duel/create"] -- "updated" --> B["Unified redirect to /duel"]
B -- "applied in" --> C["Duel.page.tsx"]
B -- "applied in" --> D["DuelBody.tsx"]
Verify that redirecting to /duel (instead of /duel/create) correctly renders the party screen and supports observer vs playable modes per the acceptance criteria for /duel/current and /duel/{lobbyCode}.
if(!lobbyCode){return(<ToastWithRedirectto={"/duel"}message={"Please join or create a party first."}/>
Confirm that redirecting generic errors to /duel won’t trap users in a loop and that the party screen can recover and guide users to start or leave a duel as required by the task.
if(status==="error"||error){return(<ToastWithRedirectto={"/duel"}message={"Hmm, something went wrong."}/>);
Ensure /duel route properly handles the “join or create a duel first” flow and clearly differentiates between observer (/duel/{lobbyCode}) and playable (/duel/current) states.
if(!data||!data.success){return(<ToastWithRedirectto={"/duel"}message={"Please join or create a duel first."}/>);
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tahminator
force-pushed
the
594-2
branch
2 times, most recently
from
594
Description of changes
Checklist before review
Screenshots
Not needed